Draft
Conversation
iglesu
force-pushed
the
tickets/DM-48005
branch
from
9b3364d to
b0631ab
Compare
move maintel modules adjust imports uppdate Jenkins and pyproject configurations, README files, etc
The `get_scripts_dir` function works relative to the `ts_standardscripts` repo. Refactor this function to be relative to `ts_maintel_standardscripts` instead so the `test_executable` unit test can find the script in the `data` dir.
Split `ts_maintel_standardscripts` repo from `ts_standardscripts` to focus exclusively on main telescope logic. fix unittest test_maintel_track_target_and_take_image_comcam.py to point to comcam script rather than auxtel one.
Refactored the test_executable unit test methods into one file. The file lives in the ts_standardardscripts repo/tests/test_maintel_executables.py The actual scripts in the data/scripts directory has been deleted from the ts_maintel_standardscripts repo and reinstated in the ts_standardscripts.
iglesu
force-pushed
the
tickets/DM-48005
branch
from
b0631ab to
e22a1d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch represents the ts_maintel_standardscripts