Update precommit rules and doc compilation #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
| @@ -70,7 +70,7 @@ def log_debug(logger: logger, msg: str, verbose: bool = False) -> None: | |||
|
|
|||
| Parameters | |||
| ---------- | |||
| logger : logger | |||
| logger : logging.Logger | |||
There was a problem hiding this comment.
❌ New issue: Code Duplication
The module contains 4 functions with similar structure: log_debug,log_error,log_info,log_warning
for more information, see https://pre-commit.ci
Comment on lines
+162
to
+213
| def linkcode_resolve(domain, info): | ||
| """ | ||
| Determine the URL corresponding to Python object | ||
| """ | ||
| if domain != "py": | ||
| return None | ||
|
|
||
| modname = info["module"] | ||
| fullname = info["fullname"] | ||
|
|
||
| submod = sys.modules.get(modname) | ||
| if submod is None: | ||
| return None | ||
|
|
||
| obj = submod | ||
| for part in fullname.split("."): | ||
| try: | ||
| obj = getattr(obj, part) | ||
| except AttributeError: | ||
| return None | ||
|
|
||
| try: | ||
| fn = inspect.getsourcefile(inspect.unwrap(obj)) | ||
| except TypeError: | ||
| try: # property | ||
| fn = inspect.getsourcefile(inspect.unwrap(obj.fget)) | ||
| except (AttributeError, TypeError): | ||
| fn = None | ||
| if not fn: | ||
| return None | ||
|
|
||
| try: | ||
| source, lineno = inspect.getsourcelines(obj) | ||
| except TypeError: | ||
| try: # property | ||
| source, lineno = inspect.getsourcelines(obj.fget) | ||
| except (AttributeError, TypeError): | ||
| lineno = None | ||
| except OSError: | ||
| lineno = None | ||
|
|
||
| if lineno: | ||
| linespec = f"#L{lineno}-L{lineno + len(source) - 1}" | ||
| else: | ||
| linespec = "" | ||
|
|
||
| fn = os.path.relpath(fn, start=os.path.dirname(disdrodb.__file__)) | ||
|
|
||
| if "+" in disdrodb.__version__: | ||
| return f"https://github.com/ltelab/disdrodb/blob/main/disdrodb/{fn}{linespec}" | ||
| else: | ||
| return f"https://github.com/ltelab/disdrodb/blob/" f"v{disdrodb.__version__}/disdrodb/{fn}{linespec}" |
There was a problem hiding this comment.
❌ New issue: Complex Method
linkcode_resolve has a cyclomatic complexity of 15, threshold = 9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prework
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and communicate accordingly:
The PR fulfills these requirements:
reader-<institute>-<campaign>bugfix-<some_key>-<word>doc-<some_key>-<word>feature-<some_key>-<word>refactor-<some_key>-<word>optimize-<some_key>-<word>fix #xxx[,#xxx], where "xxx" is the issue number)Summary
Update precommits rules and documentation compilation.