Skip to content

Improve test coverage #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 1, 2025
Merged

Improve test coverage #225

merged 10 commits into from
Jun 1, 2025

Conversation

ghiggi
Copy link
Collaborator

@ghiggi ghiggi commented May 22, 2025

Prework

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and communicate accordingly:

The PR fulfills these requirements:

  • It's submitted to the branch named as follow :
    • Add a reader: reader-<institute>-<campaign>
    • Fix a bug: bugfix-<some_key>-<word>
    • Improve the doc: doc-<some_key>-<word>
    • Add a new feature: feature-<some_key>-<word>
    • Refactor some code: refactor-<some_key>-<word>
    • Optimize some code: optimize-<some_key>-<word>
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • Don't forget to link PR to issue if you are solving one.
  • All tests are passing.
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Related GitHub issues and Pull Requests

  • Ref: #

Summary

Please explain the purpose and scope of your contribution.

Copy link

codecov bot commented May 27, 2025

Codecov Report

Attention: Patch coverage is 96.47059% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.81%. Comparing base (28ae0cd) to head (642ef68).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
disdrodb/l2/empirical_dsd.py 95.00% 2 Missing ⚠️
disdrodb/api/io.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
- Coverage   85.90%   85.81%   -0.10%     
==========================================
  Files          90       90              
  Lines        6804     6838      +34     
==========================================
+ Hits         5845     5868      +23     
- Misses        959      970      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 85.666% (-0.08%) from 85.742%
when pulling 591a226 on ghiggi:add-test-units
into 28ae0cd on ltelab:main.

@coveralls
Copy link
Collaborator

coveralls commented May 27, 2025

Coverage Status

coverage: 85.652% (-0.09%) from 85.742%
when pulling 642ef68 on ghiggi:add-test-units
into 28ae0cd on ltelab:main.

@ghiggi ghiggi merged commit ae882b0 into ltelab:main Jun 1, 2025
13 of 18 checks passed
@ghiggi ghiggi deleted the add-test-units branch June 6, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants