Add GitHub Actions workflow for building modules #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lneto
requested review from
carloslack,
jperon,
marcelstanley and
sheharyaar
Member
|
Should the workflow also try to load the kernel module after building just for a better check ? |
Collaborator
This would be bordering tests domain IMO |
carloslack
reviewed
Dec 29, 2025
.github/workflows/build.yaml
Outdated
| make -j$(nproc) | ||
| - name: Verify modules built | ||
| run: | | ||
| test -f lunatik.ko || test -f lib/lunatik.ko || (echo "Build failed" && exit 1) |
Collaborator
There was a problem hiding this comment.
Is it really needed to test for lib/lunatik.ko ?
Contributor
Author
I feel like, they are not required. This catches most of missed cases (which is rare), XD.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
https://github.com/Physic69/lunatik/pulls
for working