Add mapgen descriptions #16237
Open
Add mapgen descriptions #16237
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zughy
added
Roadmap: supported by core dev
This was referenced Jun 10, 2025
sfan5
requested changes
Jun 17, 2025
sfan5
requested changes
Jun 20, 2025
| retval = retval .. | ||
| "label[0,2;" .. fgettext("Mapgen") .. "]".. | ||
| "dropdown[0,2.5;6.3;dd_mapgen;" .. mglist .. ";" .. selindex .. "]".. | ||
| "textarea[0.5,3.2;6,2;;;" .. mapgens_descriptions[current_mg] .. "]" |
There was a problem hiding this comment.
so the dropdown will disappear if for some reason there is no description, why?
There was a problem hiding this comment.
^ this is still unresolved?
| fractal = fgettext("Wold with fractal structure."), | ||
| singlenode = fgettext("Empty world, use for lua defined mapgens."), | ||
| v6 = fgettext("Simple mapgen with few features, not recommended."), | ||
| } |
There was a problem hiding this comment.
nitpick: none of these are full sentences so there should be no full stop at the end
sfan5
added
the
Action / change needed
Co-authored-by: sfan5 <[email protected]>
Co-authored-by: sfan5 <[email protected]>
Co-authored-by: sfan5 <[email protected]>
Co-authored-by: sfan5 <[email protected]>
farooqkz
reviewed
Jul 2, 2025
| flat = fgettext("Flat world terrain"), | ||
| fractal = fgettext("World with a fractal structure"), | ||
| singlenode = fgettext("Empty world, commonly used for Lua-defined mapgens"), | ||
| v6 = fgettext("Simple mapgen with few features"), |
There was a problem hiding this comment.
What "new" features? A few words would be good
There was a problem hiding this comment.
If you're refering to V6. It says few features.
Zughy
added
Action / change needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds mapgen description when creating a world. Closes #1033
To do
Ready for Review.
How to test
Pull, compile, create world in desired game, observe descriptions.