Skip to content

[no squash] Miscellanous but important bug fixes #16340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 16, 2025
Merged

Conversation

sfan5
Copy link
Collaborator

@sfan5 sfan5 commented Jul 15, 2025

see commit msgs.
last one relates to https://github.com/orgs/luanti-org/discussions/139.

To do

This PR is Ready for Review.

How to test

meh

@sfan5 sfan5 added this to the 5.13.0 milestone Jul 15, 2025
@sfan5 sfan5 force-pushed the misc1 branch 2 times, most recently from 6a98d4d to 7230601 Compare July 15, 2025 11:06
Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☑️ Update detection still works for ContentDB-provided mods and no errors for .git cloned mods (I hope this is the correct way to test it)
☑️ The log message changes look good (generally)

Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfan5 sfan5 merged commit 251488b into luanti-org:master Jul 16, 2025
17 of 19 checks passed
@sfan5 sfan5 deleted the misc1 branch July 16, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants