Skip to content

Conversation

Verma-Punit
Copy link
Contributor

Summary

This PR introduces a new gradient text format that enhances visual appeal and allows for more engaging typography styles.

Screenshots / Screen Recording / Logs

Screen.Recording.2025-08-08.at.5.04.33.PM.1.mov

@Verma-Punit Verma-Punit requested a review from ajitbohra August 12, 2025 06:37
@Verma-Punit Verma-Punit self-assigned this Aug 12, 2025
@Verma-Punit Verma-Punit added the enhancement New feature or request label Aug 12, 2025
Copy link

github-actions bot commented Aug 12, 2025

Playground Preview

⚡️WordPress Playground Preview
🚀 Build zip file Download

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the pull request as you would on a real site, but please note that changes are not saved between sessions.

Copy link
Collaborator

@nagpai nagpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a review with a few minor suggestions. The changes work very well though when I tested on a Playground site!

isActive,
}) {
const name = 'blablablocks/gradient-text'; // Format type name
const PREFIX = 'background:';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const PREFIX = 'background:';
const PREFIX = 'background-image:';

Minor and non-blocking: Should we make the attribute more specific, since we seem to be manipulating the background-image property?

image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we choose to keep the custom clear button, it shows enabled when there is no gradient selection done. It should show grayed when there is no selection done yet.

image

__next40pxDefaultSize
>
{__('Clear', 'blablablocks-formats')}
</Button>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that we are not using the Clear button provided within the GradientPicker component and use a custom Clear button instead. I did a test by reverting to the GradientPicker built-in clear button ( setting clearable to true ), it seems to work fine.

Is there any reason we are overriding that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants