Skip to content

fix(icons): changed school icon #2968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

karsa-mistmere
Copy link
Member

What is the purpose of this pull request?

  • Other: Icon update

Description

Fixed design guideline violations

Before Submitting

@github-actions github-actions bot added the 🎨 icon About new icons label Mar 31, 2025
Copy link
Contributor

github-actions bot commented Mar 31, 2025

Added or changed icons

icons/school.svg

Preview cohesion icons/message-square.svg
icons/school.svg
icons/message-square-dashed.svg
Preview stroke widths icons/school.svg
icons/school.svg
icons/school.svg
DPI Preview

16px (shadcn/ui)

icons/school.svg

24px (default)

icons/school.svg

32px (shadcn/ui + retina)

icons/school.svg

48px (default + retina)

icons/school.svg
Icon X-rays icons/school.svg
Icon Diffs icons/school.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const SchoolIcon = createLucideIcon('School', [
  ["path",{"d":"M14 21v-3a2 2 0 0 0-4 0v3"}],
  ["path",{"d":"M18 5v16"}],
  ["path",{"d":"m4 6 7.106-3.79a2 2 0 0 1 1.788 0L20 6"}],
  ["path",{"d":"m6 11-3.52 2.147a1 1 0 0 0-.48.854V19a2 2 0 0 0 2 2h16a2 2 0 0 0 2-2v-5a1 1 0 0 0-.48-.853L18 11"}],
  ["path",{"d":"M6 5v16"}],
  ["circle",{"cx":"12","cy":"9","r":"2"}]
])

Copy link
Member

@jguddas jguddas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels a bit too rocket-y for me.

@karsa-mistmere
Copy link
Member Author

It feels a bit too rocket-y for me.

I see what you mean, but with the roof I think it's nowhere near as bad as #2971 was.

@ericfennis
Copy link
Member

I see what @jguddas means 😅.
Personally I'm not sure about the 3D effect.

@karsa-mistmere
Copy link
Member Author

karsa-mistmere commented Jul 29, 2025

@ericfennis @jguddas We could maybe just decrease the height by 1px then, similarly as it currently is in university:

image

icons
Open lucide studio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants