Skip to content

feat(icons): added road icon #3014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

uibalint
Copy link

@uibalint uibalint commented Apr 10, 2025

What is the purpose of this pull request?

  • New Icon

Description

Added new road icon.

Icon use case

In my case, I need it for a package tracking process, where I want to indicate that the package is on its way, and I’d like to use the image of a road for this purpose.
I can also imagine it being used on a map to show the type of road, such as asphalt or dirt road.

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to two points of precision.

Before Submitting

Copy link
Contributor

github-actions bot commented Apr 10, 2025

Added or changed icons

icons/road.svg

Preview cohesion icons/square-arrow-down.svg
icons/road.svg
icons/recycle.svg
Preview stroke widths icons/road.svg
icons/road.svg
icons/road.svg
DPI Preview

16px (shadcn/ui)

icons/road.svg

24px (default)

icons/road.svg

32px (shadcn/ui + retina)

icons/road.svg

48px (default + retina)

icons/road.svg
Icon X-rays icons/road.svg
Icon Diffs icons/road.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const RoadIcon = createLucideIcon('Road', [
  ["path",{"d":"M12 16v5"}],
  ["path",{"d":"M12 5V3"}],
  ["path",{"d":"M12 9v3"}],
  ["path",{"d":"M16 21h4a2 2 0 0 0 1.924-2.55l-4-14A2 2 0 0 0 16 3"}],
  ["path",{"d":"M8 3a2 2 0 0 0-1.924 1.45L2.077 18.449A2 2 0 0 0 4 21h4"}]
])

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool I like it.
I think we can also add variants with for example a snowflake to indicate "road" conditions.

@jguddas
Copy link
Member

jguddas commented Apr 18, 2025

I'm not a fan, feels very brutalistic, I would love a bit of a swoosh and curve and cuteness.

Copy link
Member

@jguddas jguddas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like it, needs more cuteness.

@karsa-mistmere
Copy link
Member

Hi @uibalint,

Nice work on this, it does look clean and minimalistic.

That said, I do think that @jguddas also has a point. I've let this sit for a while because I had a similar feeling — like something was missing — even though I couldn't quite put my finger on it at the time.

Now, I think I see what it is: somewhat counterintuitively, the lack of a clear start and end makes the icon harder to read. For example, if it were filled, we might expect something like this:

image

Which, with strokes only, would be analogous to:

outlined road icon

i.e.:
icons
Open lucide studio

@jguddas, lmkwyt

@jguddas
Copy link
Member

jguddas commented Jul 21, 2025

I like it, maybe we can make it look more 3d and less like a flip icon by making the dashes become shorter and more frequently the higher up we go.

@karsa-mistmere
Copy link
Member

I like it, maybe we can make it look more 3d and less like a flip icon by making the dashes become shorter and more frequently the higher up we go.

I already tried to do that. 😅

Here are two alternative layouts:

icons
Open lucide studio

icons
Open lucide studio

@karsa-mistmere karsa-mistmere requested review from ericfennis and removed request for karsa-mistmere July 21, 2025 15:16
@jguddas
Copy link
Member

jguddas commented Jul 21, 2025

Looks weird, but at 100% scale feels quite nice.
icons
Open lucide studio

@karsa-mistmere
Copy link
Member

Looks weird, but at 100% scale feels quite nice. iconsOpen lucide studio

Not bad at all, actually. 🤔

@ericfennis
Copy link
Member

To me looks fine as well. Go for it @jguddas!

@karsa-mistmere
Copy link
Member

Dunno, now looking at them all at 100%, @jguddas' version feels a bit weird, as if it was some sort of reflect icon. 🤔

image
image

@ericfennis
Copy link
Member

@karsa-mistmere Hmm true, maybe the last one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants