-
-
Notifications
You must be signed in to change notification settings - Fork 891
fix(icons): Changed a-large-small
icon
#3396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Added or changed iconsIcons as codeWorks for: const ALargeSmallIcon = createLucideIcon('ALargeSmall', [
["path",{"d":"m15 16 3-6 3 6"}],
["path",{"d":"M15.5 15h5"}],
["path",{"d":"m3 16 4-8 4 8"}],
["path",{"d":"M4 14h6"}]
])
const CaseLowerIcon = createLucideIcon('CaseLower', [
["path",{"d":"M10 10v6"}],
["path",{"d":"M14 8v8"}],
["circle",{"cx":"17","cy":"13","r":"3"}],
["circle",{"cx":"7","cy":"13","r":"3"}]
])
const CaseSensitiveIcon = createLucideIcon('CaseSensitive', [
["path",{"d":"M21 10v6"}],
["path",{"d":"m3 16 4-8 4 8"}],
["path",{"d":"M4 14h6"}],
["circle",{"cx":"18","cy":"13","r":"3"}]
])
const CaseUpperIcon = createLucideIcon('CaseUpper', [
["path",{"d":"M15 12h4.5a2 2 0 0 1 0 4H15V8h4a2 2 0 0 1 0 4"}],
["path",{"d":"m3 16 4-8 4 8"}],
["path",{"d":"M4 14h6"}]
]) |
Moving it down 1px looks nice, reducing the size is a bad idea, it breaks the 2px gap rule and the rule for visual size. |
Hi @vichotech, Thanks for the update — I appreciate the intention behind these changes. For Regarding the baseline adjustments in |
Here's one idea to increase the size, have better centre of gravity and get rid of the awkward Edit, alternatively: But this doesn't feel much better. |
What is the purpose of this pull request?
Description
a-large-small
: Reduced the scale of the larger A to make it more consistent with the other icons where this symbol is used. Modified the shape of the smaller A to better convey the concept: a change from one size to another (instead of a change from one character to another). Moved the baseline of both characters 1px lower to visually center the icon more effectively.case-sensitive
: Moved the baseline of both characters 1px lower to visually center the icon more effectively.case-lower
: Moved the baseline of both characters 1px lower to visually center the icon more effectively.case-upper
: Moved the baseline of both characters 1px lower to visually center the icon more effectively.Before Submitting