-
-
Notifications
You must be signed in to change notification settings - Fork 917
feat(icons): added smartphone-down
and smartphone-notch
icons
#3478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 ChatGPT Tags suggestions ✨
I've asked ChatGPT for some suggestions for tags.
"contributors": [ | ||
"tallneil" | ||
], | ||
"tags": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions for the smartphone-down
icon.
Try asking it your self if you want more suggestions. Open ChatGPT
Here are the suggestions:
"tags": [ | |
"tags": [ | |
"smartphone", | |
"fall", | |
"accident", | |
"damage", | |
"drop", | |
"crash", | |
"broken", | |
"disappointment", | |
"fault", | |
"failure", |
"contributors": [ | ||
"tallneil" | ||
], | ||
"tags": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions for the smartphone-notch
icon.
Try asking it your self if you want more suggestions. Open ChatGPT
Here are the suggestions:
"tags": [ | |
"tags": [ | |
"smartphone", | |
"notch", | |
"technology", | |
"mobile", | |
"display", | |
"cutout", | |
"tech", | |
"electronics", |
Added or changed iconsIcons as codeWorks for: const SmartphoneDownIcon = createLucideIcon('SmartphoneDown', [
["rect",{"width":"14","height":"20","x":"5","y":"2","rx":"2","ry":"2"}],
["path",{"d":"M14 3L10 3"}],
["path",{"d":"M12 15V9"}],
["path",{"d":"M15 12L12 15L9 12"}]
])
const SmartphoneNotchIcon = createLucideIcon('SmartphoneNotch', [
["rect",{"width":"14","height":"20","x":"5","y":"2","rx":"2","ry":"2"}],
["path",{"d":"M14 3L10 3"}]
]) |
Hey @tallneil, This design violates our 2px gap design guideline. This would be compliant, but looks less like a notch and more like Apple's Dynamic Island™, about which I'm not prepared to receive any legal notices, so I think this will not go through, unfortunately. |
Description
Added 2 new smartphone icons:
smartphone-notch
andsmartphone-down
Icon use case
smartphone
is an existing Lucide icon which represents a device with a physical home button.smartphone-notch
represents a more modern device with no home button, and a notch at the top of the screen. This is useful for representing modern smartphones and apps.smartphone-down
represents downloading something related to a smartphone, for instance, downloading an app. This new icon complements the existing set of-down
icons, includingmonitor-down
,folder-down
, andfile-down
.Alternative icon designs
N/A
Icon Design Checklist
Concept
Author, credits & license
smartphone
,monitor-down
,folder-down
,file-down
Naming
icons/[iconName].json
.Design
Before Submitting