Skip to content

feat(icons): added 'panel-dashed' variants + update tags on existing icons #3500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

irvineacosta
Copy link
Contributor

Description

Added new variants to the panel-dashed icon set:

  • panel-left-right-dashed
  • panel-top-right-dashed
  • panel-all-sides-dashed

Also updated the json files of existing icons to include:

  • margin
  • padding
  • guide

Icon use case

These icons will be used to represent paddings or margins, for example when customizing a UI element:
image

Alternative icon designs

image image

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons: panel-dashed icon set (e.g. panel-top-dashed)
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Aug 4, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 ChatGPT Tags suggestions ✨

I've asked ChatGPT for some suggestions for tags.

"ericfennis",
"irvineacosta"
],
"tags": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions for the panel-all-sides-dashed icon.
Try asking it your self if you want more suggestions. Open ChatGPT
Here are the suggestions:

Suggested change
"tags": [
"tags": [
"panel",
"sides",
"dashed",
"border",
"frame",
"outline",
"bordered",
"box",
"canvas",
"edge",

@@ -2,13 +2,18 @@
"$schema": "../icon.schema.json",
"contributors": [
"danielbayley",
"ericfennis"
"ericfennis",
"irvineacosta"
],
"tags": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions for the panel-bottom-dashed icon.
Try asking it your self if you want more suggestions. Open ChatGPT
Here are the suggestions:

Suggested change
"tags": [
"tags": [
"panel",
"bottom",
"dashed",
"line",
"border",
"underline",
"style",
"separator",
"glitch",
"bordered",

@@ -2,14 +2,19 @@
"$schema": "../icon.schema.json",
"contributors": [
"danielbayley",
"ericfennis"
"ericfennis",
"irvineacosta"
],
"tags": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions for the panel-left-dashed icon.
Try asking it your self if you want more suggestions. Open ChatGPT
Here are the suggestions:

Suggested change
"tags": [
"tags": [
"panel",
"left",
"dashed",
"border",
"outline",
"line",
"shape",
"graphic",
"design",

"ericfennis",
"irvineacosta"
],
"tags": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions for the panel-left-right-dashed icon.
Try asking it your self if you want more suggestions. Open ChatGPT
Here are the suggestions:

Suggested change
"tags": [
"tags": [
"panel",
"left",
"right",
"dashed",
"border",
"line",
"divider",
"separator",
"split",
"section",

@@ -2,14 +2,19 @@
"$schema": "../icon.schema.json",
"contributors": [
"danielbayley",
"ericfennis"
"ericfennis",
"irvineacosta"
],
"tags": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions for the panel-right-dashed icon.
Try asking it your self if you want more suggestions. Open ChatGPT
Here are the suggestions:

Suggested change
"tags": [
"tags": [
"panel",
"right",
"dashed",
"border",
"outline",
"line",
"frame",
"edge",
"section",

"ericfennis",
"irvineacosta"
],
"tags": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions for the panel-top-bottom-dashed icon.
Try asking it your self if you want more suggestions. Open ChatGPT
Here are the suggestions:

Suggested change
"tags": [
"tags": [
"panel",
"top",
"bottom",
"dashed",

@@ -2,13 +2,18 @@
"$schema": "../icon.schema.json",
"contributors": [
"danielbayley",
"ericfennis"
"ericfennis",
"irvineacosta"
],
"tags": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions for the panel-top-dashed icon.
Try asking it your self if you want more suggestions. Open ChatGPT
Here are the suggestions:

Suggested change
"tags": [
"tags": [
"panel",
"top",
"dashed",
"border",
"line",
"separator",
"style",
"graphic",
"design",
"outline",

Copy link
Contributor

github-actions bot commented Aug 4, 2025

Added or changed icons

icons/panel-left-right-dashed.svgicons/panel-top-bottom-dashed.svg

Preview cohesion icons/square-terminal.svgicons/square-code.svg
icons/panel-left-right-dashed.svgicons/panel-top-bottom-dashed.svg
icons/feather.svgicons/share-2.svg
Preview stroke widths icons/panel-left-right-dashed.svgicons/panel-top-bottom-dashed.svg
icons/panel-left-right-dashed.svgicons/panel-top-bottom-dashed.svg
icons/panel-left-right-dashed.svgicons/panel-top-bottom-dashed.svg
DPI Preview

16px (shadcn/ui)

icons/panel-left-right-dashed.svg icons/panel-top-bottom-dashed.svg

24px (default)

icons/panel-left-right-dashed.svg icons/panel-top-bottom-dashed.svg

32px (shadcn/ui + retina)

icons/panel-left-right-dashed.svg icons/panel-top-bottom-dashed.svg

48px (default + retina)

icons/panel-left-right-dashed.svg icons/panel-top-bottom-dashed.svg
Icon X-rays icons/panel-left-right-dashed.svg icons/panel-top-bottom-dashed.svg
Icon Diffs icons/panel-left-right-dashed.svg icons/panel-top-bottom-dashed.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const PanelLeftRightDashedIcon = createLucideIcon('PanelLeftRightDashed', [
  ["path",{"d":"M16 10V9"}],
  ["path",{"d":"M16 15v-1"}],
  ["path",{"d":"M16 21v-2"}],
  ["path",{"d":"M16 5V3"}],
  ["path",{"d":"M8 10V9"}],
  ["path",{"d":"M8 15v-1"}],
  ["path",{"d":"M8 21v-2"}],
  ["path",{"d":"M8 5V3"}],
  ["rect",{"x":"3","y":"3","width":"18","height":"18","rx":"2"}]
])

const PanelTopBottomDashedIcon = createLucideIcon('PanelTopBottomDashed', [
  ["path",{"d":"M14 16h1"}],
  ["path",{"d":"M14 8h1"}],
  ["path",{"d":"M19 16h2"}],
  ["path",{"d":"M19 8h2"}],
  ["path",{"d":"M3 16h2"}],
  ["path",{"d":"M3 8h2"}],
  ["path",{"d":"M9 16h1"}],
  ["path",{"d":"M9 8h1"}],
  ["rect",{"x":"3","y":"3","width":"18","height":"18","rx":"2"}]
])

@irvineacosta
Copy link
Contributor Author

@karsa-mistmere @jguddas as discussed here's the PR that expands the existing panel-dashed icons 😁

@jguddas
Copy link
Member

jguddas commented Aug 4, 2025

  1. You should not duplicate icons that are just rotated versions of other icons.
  2. panel-all-sides-dashed does not look like panels, I would go with feat(icons): added square-square-dashed icon #3499 instead.

In short: I would remove all icons besides panel-left-right-dashed.

@karsa-mistmere
Copy link
Member

karsa-mistmere commented Aug 4, 2025

  1. You should not duplicate icons that are just rotated versions of other icons.

Please don't state this as fact, we should postpone merging orientations, as we are in no way ready for handling the automation of mirrored and rotated variants.

Forcing people to use CSS transforms is not an option, since browsers (and HTML in general) are not our only target.

@irvineacosta
Copy link
Contributor Author

  1. You should not duplicate icons that are just rotated versions of other icons.

Please don't state this as fact, we should postpone merging orientations, as we are in no way ready for handling the automation of mirrored and rotated variants.

Forcing people to use CSS transforms is not an option, since browsers (and HTML in general) are not our only target.

@jguddas it's also not possible to rotate instances inside figma components without detaching them.

@jguddas
Copy link
Member

jguddas commented Aug 4, 2025

  1. You should not duplicate icons that are just rotated versions of other icons.

Please don't state this as fact, we should postpone merging orientations, as we are in no way ready for handling the automation of mirrored and rotated variants.

Forcing people to use CSS transforms is not an option, since browsers (and HTML in general) are not our only target.

@jguddas it's also not possible to rotate instances inside figma components without detaching them.

I changed my mind, I think it's good as long as they have a unique use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants