tweet を id から取得する関数を追加 #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmatsuoka
commented
Sep 12, 2023
There was a problem hiding this comment.
これは散らばっていた client の関数をまとめた。
変更した箇所は getJSON でエラーメッセージにレスポンスボディを追加したこと。
rmatsuoka
commented
Sep 12, 2023
| @@ -93,65 +84,11 @@ func (c *Client) RecentSearch(q string) ([]*Tweet, error) { | |||
|
|
|||
| tweets := make([]*Tweet, 0, len(resp.Data)) | |||
| for _, d := range resp.Data { | |||
| // tweet オブジェクトに含まれるのは auther_id (数字の並び)のみ | |||
There was a problem hiding this comment.
ここの消した部分は新しい関数 Tweets と共通化するために types.go に移動した
rmatsuoka
commented
Sep 12, 2023
There was a problem hiding this comment.
ここは全く新しいファイルで tweet を id から取得するメソッドを定義している
rmatsuoka
commented
Sep 12, 2023
There was a problem hiding this comment.
もとは recent_test.go だったもの。TestTweets 追加にあたってファイルの名前が変わった。
lufia
approved these changes
Sep 13, 2023
| Host: Host, | ||
| Path: TweetsPath, | ||
| // A space should be escaped into '%20' instead of '+' on twitter's query parameter. | ||
| RawQuery: strings.Replace(v.Encode(), "+", "%20", -1), |
|
みました、マージします |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
saba_dsambiguator が学習の際にデータセットとして tweet を id から取得する必要があったので、その関数を追加
how
/2/tweetsを叩いて id から tweet を取得。check