Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ノイズが多い場合は事前に除外しておくオプションを追加 #259

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

lufia
Copy link
Owner

@lufia lufia commented Nov 20, 2023

やったこと

  • spam パラメータをconfigに追加した
  • ポストの body に部分文字列でマッチして、どれか1つでもマッチしたポストは検出判定せずに落とす

代わりの案

  • 部分文字列ではなく正規表現にする
  • body だけではなく screenName などにも対応する

こういった案もあるが、いったんは素朴に実装しておくことにした。

@lufia lufia requested a review from rmatsuoka November 20, 2023 10:48
@lufia lufia self-assigned this Nov 20, 2023
Copy link
Collaborator

@rmatsuoka rmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lufia lufia merged commit bb052aa into main Nov 22, 2023
2 checks passed
@lufia lufia deleted the exclude-opt branch November 22, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants