Numpy 2 update temporary fixes #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After Numpy's new releases, a few bugs appeared that are related to Numpy and its interaction with Pytorch.
After a couple of weeks they still have not been fixed, the tests are failing and the installation is then unstable.
A temporary fixed should be done.
This sets numpy<2 in the requirements for now because on macos numpy>2 just doesn't work with pytorch yet.
Also, it fixes preventively this silly issue related to Numpy>2
np.meshgridoutput from list to tuple madecompute_fescrashQuestions
Status