Removes django admin #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,17 +1,17 @@ | |||
| # -*- coding: utf-8 -*- | |||
| from pyboleto.data import BoletoData, custom_property | |||
| from pyboleto.data import BoletoData, CustomProperty | |||
There was a problem hiding this comment.
Não lembro muito bem como estão os testes, mas será que não vale fazer um que quebrasse antes de fazer o fix?
|
Nem sabia que esse projeto tem django_admin, pois nunca precisamos. Mas daí eu fiquei na dúvida se existe a chance de alguém precisar dele no futuro. 🤔 |
|
Obrigado pela contribuição! 🎉 ❤️ |
Acho que se não está sendo usado é melhor remover. ❤️ |
added 8 commits
January 9, 2020 17:07
Removes basestring to support python3 See merge request luizalabs/pyboleto!7
Fix expected xml tests See merge request luizalabs/pyboleto!9
Add gitlab ci See merge request luizalabs/pyboleto!11
Add pypi dependencies See merge request luizalabs/pyboleto!12
rafaelgotts
approved these changes
Oct 15, 2020
erikopa
force-pushed
the
em-removes_django_admin
branch
from
c478143
to
8dc4340
Compare
erikopa
force-pushed
the
em-removes_django_admin
branch
from
8dc4340
to
8b6704d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
custom_propertytoCustomPropertyin sicred module