Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👮 Support adding a specific clone token #245

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

MadsBogeskov
Copy link
Contributor

@MadsBogeskov MadsBogeskov commented Sep 16, 2024

Overall Idea

Some shuttle repositories might not be accessible from the runner, e.g. if all repositories are placed in a private GitHub organisation. Historically this has been solved by overriding the clone path in the GitHub Action like so:

- name: Test
  run: shuttle run build_framework github_token=${{ secrets.GITHUB_TOKEN }} --plan https://${{ secrets.IOS_BOT_TOKEN }}@github.com/lunarway/shuttle-ios-plan.git#main

Instead we would like to just being able to use the plan specified in the shuttle file and just set a access token from inside the action instead, making it look like this:

- name: Build
  run: shuttle run build_framework
  env:
    SHUTTLE_GIT_TOKEN: ${{ steps.token.outputs.token }}

@MadsBogeskov MadsBogeskov requested a review from a team as a code owner September 16, 2024 12:12
pkg/git/git.go Outdated Show resolved Hide resolved
pkg/git/git.go Outdated Show resolved Hide resolved
@MadsBogeskov MadsBogeskov requested a review from kjuulh September 16, 2024 12:28
@MadsBogeskov MadsBogeskov merged commit 7a4d06d into master Sep 16, 2024
2 checks passed
@MadsBogeskov MadsBogeskov deleted the add_https_access_token_support branch September 16, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants