Skip to content

restore history support in idea 2016.2 #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

OlegYch
Copy link

@OlegYch OlegYch commented Feb 4, 2015

not sure what runExecuteAction was for, but it's not called anywhere atm, so i removed it

@retronym retronym self-assigned this Feb 5, 2015
@retronym
Copy link
Collaborator

retronym commented Feb 5, 2015

I think the fix is a touch more involved: that method was called by a base class in IDEA 13 and was used to turn the prompt on/off during execution of a task. Thanks for the push, though: I'll schedule some time next week to set about fixing this one way or the other.

@OlegYch
Copy link
Author

OlegYch commented Feb 11, 2015

there seems to be something else involved, i occasionally get this:

Element: class com.intellij.psi.impl.source.PsiPlainTextFileImpl because: different providers: {myVirtualFile=LightVirtualFile: \SBT, content=VirtualFileContent{size=0}}(6c08b252); {myVirtualFile=LightVirtualFile: \SBT, content=VirtualFileContent{size=0}}(2ef35ce7)
invalidated at: no info
com.intellij.psi.PsiInvalidElementAccessException: Element: class com.intellij.psi.impl.source.PsiPlainTextFileImpl because: different providers: {myVirtualFile=LightVirtualFile: \SBT, content=VirtualFileContent{size=0}}(6c08b252); {myVirtualFile=LightVirtualFile: \SBT, content=VirtualFileContent{size=0}}(2ef35ce7)
invalidated at: no info
    at com.intellij.psi.util.PsiUtilCore.ensureValid(PsiUtilCore.java:479)
    at com.intellij.psi.util.PsiUtilBase.getPsiFileInEditor(PsiUtilBase.java:132)
    at com.intellij.psi.util.PsiUtilBase.getPsiFileInEditor(PsiUtilBase.java:123)
    at com.intellij.codeInsight.lookup.impl.LookupTypedHandler.execute(LookupTypedHandler.java:62)
    at com.intellij.execution.impl.ConsoleViewImpl$MyTypedHandler.execute(ConsoleViewImpl.java:1262)
    at com.intellij.openapi.editor.actionSystem.TypedAction$TypingCommand$1.run(TypedAction.java:129)
    at com.intellij.openapi.application.impl.ApplicationImpl.runWriteAction(ApplicationImpl.java:937)
    at com.intellij.openapi.editor.actionSystem.TypedAction$TypingCommand.run(TypedAction.java:123)
    at com.intellij.openapi.command.impl.CoreCommandProcessor.executeCommand(CoreCommandProcessor.java:124)
    at com.intellij.openapi.editor.actionSystem.TypedAction.actionPerformed(TypedAction.java:107)
    at com.intellij.openapi.editor.impl.EditorImpl.a(EditorImpl.java:1062)
    at com.intellij.openapi.editor.impl.EditorImpl.processKeyTyped(EditorImpl.java:5132)
    at com.intellij.execution.console.LanguageConsoleImpl$7.keyTyped(LanguageConsoleImpl.java:273)
    at java.awt.AWTEventMulticaster.keyTyped(AWTEventMulticaster.java:223)
    at java.awt.Component.processKeyEvent(Component.java:6252)
    at javax.swing.JComponent.processKeyEvent(JComponent.java:2809)
    at java.awt.Component.processEvent(Component.java:6074)
    at java.awt.Container.processEvent(Container.java:2039)
    at java.awt.Component.dispatchEventImpl(Component.java:4660)
    at java.awt.Container.dispatchEventImpl(Container.java:2097)
    at java.awt.Component.dispatchEvent(Component.java:4488)
    at java.awt.KeyboardFocusManager.redispatchEvent(KeyboardFocusManager.java:1856)
    at java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(DefaultKeyboardFocusManager.java:722)
    at java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(DefaultKeyboardFocusManager.java:1000)
    at java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(DefaultKeyboardFocusManager.java:865)
    at java.awt.DefaultKeyboardFocusManager.dispatchEvent(DefaultKeyboardFocusManager.java:686)
    at java.awt.Component.dispatchEventImpl(Component.java:4532)
    at java.awt.Container.dispatchEventImpl(Container.java:2097)
    at java.awt.Window.dispatchEventImpl(Window.java:2489)
    at java.awt.Component.dispatchEvent(Component.java:4488)
    at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:668)
    at java.awt.EventQueue.access$400(EventQueue.java:81)
    at java.awt.EventQueue$2.run(EventQueue.java:627)
    at java.awt.EventQueue$2.run(EventQueue.java:625)
    at java.security.AccessController.doPrivileged(Native Method)
    at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
    at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:98)
    at java.awt.EventQueue$3.run(EventQueue.java:641)
    at java.awt.EventQueue$3.run(EventQueue.java:639)
    at java.security.AccessController.doPrivileged(Native Method)
    at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
    at java.awt.EventQueue.dispatchEvent(EventQueue.java:638)
    at com.intellij.ide.IdeEventQueue.e(IdeEventQueue.java:741)
    at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:546)
    at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:383)
    at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
    at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
    at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174)
    at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)
    at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)
    at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)


@ijuma
Copy link
Contributor

ijuma commented Mar 13, 2015

As 14.1 final nears (supposed to be released in Q1), I decided to give it a try and I'm already missing this plugin. :)

@nightwolfzor
Copy link

14.1 is now officially released. After upgrading it no longer works. Really missing this plugin. Would be awesome to see a PR merged for this!

@retronym
Copy link
Collaborator

I've spent a few hours today trying to make the plugin work under IDEA 14.1. No luck so far. I'll keep trying, and then push my attempt to a branch and see if I can get some help from JetBrains.

I can't figure out how to adapt to the changes in the (internal)
API of LanguageConsole. To enable a release, I've reverted to
the old style TextConsole. The main thing we sacrifice is editor
history.
@retronym
Copy link
Collaborator

To unblock use of 14.1, I've created a build that uses a simpler UI for the console, rather than the LanguageConsole.

Code: https://github.com/orfjackal/idea-sbt-plugin/compare/master...retronym:topic/idea-14.1?expand=1

Here's a build: https://dl.dropboxusercontent.com/u/106552/idea-sbt-plugin-1.7.0-SNAPSHOT.zip

Could I ask someone to try out this plugin check that things are okay?

@lanceon
Copy link

lanceon commented Mar 26, 2015

Hi,
UI is a bit different, no commands history (as described) but it works and is better than running in a separate console. IDEA build is 141.177.
Thanks!

@ijuma
Copy link
Contributor

ijuma commented Mar 27, 2015

@retronym, seems to work for me. Thanks!

@OlegYch OlegYch changed the title compatibility with idea 14.1 restore history support in idea 2016.2 Jul 24, 2016
@OlegYch
Copy link
Author

OlegYch commented Jul 24, 2016

no idea what happened in 2016.2 but it now works correctly with idea-sbt console with minimal changes
i also updated sbt launcher to 0.13.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants