Generalize image extension in test_epipolar_charuco(). #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MaticTonin / @CenekAlbl , I don't see any potential issue with the PR, do you? Otherwise we should merge it 👍 |
Collaborator
|
Agree on that one, because datasets can be any format they want. |
Author
|
Sounds like there's no objections. Can someone with write access approve? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generalizes what images can be used in test_epipolar_utils(), similar to other points in the code. This is useful if users are trying to calibrate offline using a set of jpegs generated with the on-board encoders. Thanks for considering!