Ref Gen3: Manip Config Script Replace #605
Draft
+6
−183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkbmrz
reviewed
Jan 28, 2025
| git+https://github.com/luxonis/depthai-nodes.git@feat/detection-manip-config-script |
There was a problem hiding this comment.
is this change really worth it, as we will soon merge the feat/detection-manip-config-script to main?
There was a problem hiding this comment.
I wanted to have it testable in the draft. If it was more than a line probably not.
There was a problem hiding this comment.
Also I would probably like to merge the PR when the depthai-nodes are released with the feature so I can pin the version.
jkbmrz
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
generate_script_contentscript fromdepthai-nodesinstead of local script files.Should get merged either after the
generate_script_contentscript is release indepthai-nodesor merged to main. If merged after the script is released requirements should change to the particulardepthai-nodesversion.