Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation in setters and parser structure. #138

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kkeroo
Copy link
Collaborator

@kkeroo kkeroo commented Nov 19, 2024

This PR adds some validation logic to parser's setter methods like setAnchors(). It also fixes some docstrings/types and moves some code in Embeddings parser to follow the structure: 1. Constructor, 2. setters, 3. build, 4. run.

@github-actions github-actions bot added the parsers Changes affecting ml.parsers label Nov 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 6.52174% with 43 lines in your changes missing coverage. Please review.

Project coverage is 33.04%. Comparing base (37a2d92) to head (5d1b6b4).
Report is 10 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
depthai_nodes/ml/parsers/yolo.py 0.00% 31 Missing ⚠️
depthai_nodes/ml/parsers/embeddings.py 33.33% 6 Missing ⚠️
depthai_nodes/ml/parsers/keypoints.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
- Coverage   33.40%   33.04%   -0.36%     
==========================================
  Files          68       69       +1     
  Lines        3739     3740       +1     
==========================================
- Hits         1249     1236      -13     
- Misses       2490     2504      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jkbmrz jkbmrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsers Changes affecting ml.parsers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants