-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: image creator function #188
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #188 +/- ##
==========================================
+ Coverage 41.63% 47.50% +5.86%
==========================================
Files 75 75
Lines 4285 4286 +1
==========================================
+ Hits 1784 2036 +252
+ Misses 2501 2250 -251 ☔ View full report in Codecov by Sentry. |
To discuss: |
We can since it is probably easy addition ( |
* Bug fix. * Bug fix. * Move. * Unittest for Tiling and TilesPatcher. * Add stability tests for host nodes. * Improve readability. * Renaming to stability tests.
Purpose
Outputs of the
ImageOutputParser
are not visualized correctly in DAI Visualizer due to a bug in thecreate_image_message()
creator.Specification
Changes in
create_image_message()
:.setCvFrame()
instead of.setData()
when creating thedai.ImgFrame
,img_frame_type
) to adjust the outputImgFrame.Type
to the running platform.Changes in
ImageOutputParser
:ImgFrame.Type
when calling thecreate_image_message()
.Dependencies & Potential Impact
None
Deployment Plan
None
Testing & Validation
The changes were tested by running the
generic-example
both on RVC2 and RVC4 for the following models:rt-super-resolution
esrgan
(RVC4 only)zero-dce