Migrate crop config creator node #191
Conversation
aljazkonec1
requested review from
tersekmatija,
jkbmrz,
kkeroo and
klemen1999
as code owners
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #191 +/- ##
==========================================
- Coverage 41.63% 41.41% -0.22%
==========================================
Files 75 76 +1
Lines 4285 4382 +97
==========================================
+ Hits 1784 1815 +31
- Misses 2501 2567 +66 ☔ View full report in Codecov by Sentry. |
| setReusePreviousImage flag set to False, which changes the previous frame for a | ||
| new one. | ||
| """ | ||
| assert isinstance(detections_input, ImgDetectionsExtended) |
There was a problem hiding this comment.
should we add here ... or isinstance(detections_input, dai.ImgDetection)? Might come handy if e.g. YOLO is the first model of the pipeline
|
|
||
| for i in range(num_detections): | ||
| cfg = dai.ImageManipConfigV2() | ||
| detection: ImgDetectionExtended = detections[i] |
There was a problem hiding this comment.
Are the detections sorted by confidence? Because if not, we might not send out the desired ones (e.g. if a model makes 300 detections, and we limit them to 100, then it would make sense to output the top 100 most confident ones).
Purpose
This PR migrates the
ProcessDetectionsnode, renamed toCropConfigCreatorNode, from depthai-experiments to depthai-nodes. The node simplifies the pipeline by removing one extra script node and expands the usability as it unblocks RVC2 usage. The naming of the node and any other suggestions are kindly welcome!Specification
Add a new node, called CropConfigCreatorNode. This node is used to create a dai.ImageManipConfigV2() object for every detection. The node works on both RVC2 and RVC4. Simultaneously, this node also addresses the issue with RVC2 with pool size that has been blocking depthai-experiments.
Dependencies & Potential Impact
No breaking changes outright, but an update to depthai-experiments will be needed. One risk is the way the node handles syncing of which crop config is for which frame. The node assumes the last frame is saved in the ImgManipV2 node and when recieving a detection_message it sends an empty crop config that skips the frame and loads the next frame in the queue. That frame should be the one from which the detection_message was gotten.
Deployment Plan
None / not applicable
Testing & Validation
Tested on age-gender experiment on this branch on both RVC2 and 4 for 0 to 6 faces present in the frame. No unsynced frames could be detected. PS: pay attention to how the node is used in main.py and how the following ImageManipNode (script_node) has to be set up in order for the correct sequence.