-
Notifications
You must be signed in to change notification settings - Fork 0
Feat: Add BaseHostNode #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
==========================================
+ Coverage 51.80% 51.96% +0.15%
==========================================
Files 81 82 +1
Lines 4799 4821 +22
==========================================
+ Hits 2486 2505 +19
- Misses 2313 2316 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just thinking if we should rename this base class ImageFrameSender
to more general name BaseHostNode
or something. Because its a general class and not a "sender" and it might come useful in other nodes aswell.
Maybe |
Ok, but I dont see why other nodes couldnt inherit from this node. |
That's true. There is currently no direct usage of the platform parameter in other nodes but there might come more where this will come handy (and they might not output the |
Actually I agree yeah, I think it makes sens to make it into an overall base node. Let's make sure every other inherits from it as |
I think having custom base node is good to abstract some very very common things. On the other hand I would not put too much logic that is not common/true for all our nodes. That would then over time lead to the node being very bulky, unclear and with many responsibilities as opposed to single responsibility. |
…d of string representations
39d6a17
to
2e978e3
Compare
I've renamed the node in ab06069 to |
Purpose
Based on the comment in #192, we are missing an abstract class with platform extraction functionality. Adding it limits code repetition in host nodes and centralizes the control over the
ImgFrame.Type
settings for individual platforms.Specification
Adding the
BaseHostNode
, an abstract class with platform extraction functionality, and using it as a parent in all of our host nodes.Dependencies & Potential Impact
None
Deployment Plan
None
Testing & Validation
Tested by running the
depthai-experiments/neural-networks/generic-example
using themidas-v2-1:small-256x192
model both on RVC2 and RVC4.