Skip to content

Conversation

@kozlov721
Copy link
Collaborator

  • Improved duplicate warnings
    • The warnings are not raised on empty annotations, annotations of different tasks and of different instance ids
    • The warning message contain the absolute file path instead of just the file name
    • Added the task and annotation type to the warning message
    • The content of RLE and mask segmentation annotations is not logged
  • Added option to lazy load file index
  • Added path resolving (removing . and .. directories from path)

@kozlov721 kozlov721 requested a review from a team as a code owner October 4, 2024 04:20
@kozlov721 kozlov721 requested review from conorsim, klemen1999 and tersekmatija and removed request for a team October 4, 2024 04:20
@github-actions github-actions bot added the fix Fixing a bug label Oct 4, 2024
@kozlov721 kozlov721 added the data Changes affecting luxonis_ml.data subpackage label Oct 4, 2024
@codecov
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (dev@17f6f26). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
luxonis_ml/data/datasets/luxonis_dataset.py 85.71% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #184   +/-   ##
======================================
  Coverage       ?   92.32%           
======================================
  Files          ?       79           
  Lines          ?     4129           
  Branches       ?        0           
======================================
  Hits           ?     3812           
  Misses         ?      317           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@klemen1999 klemen1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks, previous warnings were a bit excessive

@kozlov721 kozlov721 merged commit de1d69f into dev Oct 4, 2024
12 checks passed
@kozlov721 kozlov721 deleted the fix/duplicates-warn branch October 8, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data Changes affecting luxonis_ml.data subpackage fix Fixing a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants