feat: log_matrix #209
Merged
feat: log_matrix #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSabadin
requested review from
conorsim,
klemen1999,
kozlov721 and
tersekmatija
and removed request for
a team
github-actions
bot
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
==========================================
- Coverage 92.33% 92.30% -0.03%
==========================================
Files 79 79
Lines 4161 4275 +114
==========================================
+ Hits 3842 3946 +104
- Misses 319 329 +10 ☔ View full report in Codecov by Sentry. |
kozlov721
approved these changes
Nov 22, 2024
Collaborator
kozlov721
left a comment
kozlov721
left a comment
There was a problem hiding this comment.
LGTM, just left a small comment
klemen1999
reviewed
Nov 22, 2024
klemen1999
reviewed
Nov 22, 2024
klemen1999
approved these changes
Nov 25, 2024
Collaborator
klemen1999
left a comment
klemen1999
left a comment
There was a problem hiding this comment.
LGTM, left some comments
klemen1999
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to log a matrix as an artifact.