Skip to content

Conversation

@sokovninn
Copy link
Contributor

@sokovninn sokovninn commented Dec 4, 2024

This PR resolves the issue of overlapping masks in semantic segmentation targets.

Benchmark Results (1 epoch COCO, 5000 images, 8 workers):

  • Before: 4:00 minutes
  • After: 4:13 minutes (approximately 6% increase in processing time)

Notes:

The added overhead is due to the additional processing required to remove overlaps in the segmentation masks. Further optimizations may be explored if necessary.

Update:

After further optimizations there is no overhead anymore.

@sokovninn sokovninn requested a review from a team as a code owner December 4, 2024 16:49
@sokovninn sokovninn requested review from conorsim, klemen1999, kozlov721 and tersekmatija and removed request for a team December 4, 2024 16:49
@github-actions github-actions bot added the fix Fixing a bug label Dec 4, 2024
@codecov
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.34%. Comparing base (6bcbb11) to head (b8e500a).
Report is 26 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
+ Coverage   92.33%   92.34%   +0.01%     
==========================================
  Files          79       80       +1     
  Lines        4161     4324     +163     
==========================================
+ Hits         3842     3993     +151     
- Misses        319      331      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozlov721
Copy link
Collaborator

kozlov721 commented Dec 5, 2024

(approximately 6% increase in processing time)

IMHO the overhead is too big. We should check and correct this on the side of LuxonisDataset when the dataset is being created.

Copy link
Collaborator

@kozlov721 kozlov721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM! Could you just add a small test for this?

@sokovninn sokovninn merged commit e3fee91 into main Dec 6, 2024
12 checks passed
@sokovninn sokovninn deleted the fix/semseg-overlapping-masks branch December 6, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Fixing a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants