-
Notifications
You must be signed in to change notification settings - Fork 1
Fix overlapping masks in semantic segmentation targets #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
==========================================
+ Coverage 92.33% 92.34% +0.01%
==========================================
Files 79 80 +1
Lines 4161 4324 +163
==========================================
+ Hits 3842 3993 +151
- Misses 319 331 +12 ☔ View full report in Codecov by Sentry. |
IMHO the overhead is too big. We should check and correct this on the side of |
kozlov721
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM! Could you just add a small test for this?
This PR resolves the issue of overlapping masks in semantic segmentation targets.
Benchmark Results (1 epoch COCO, 5000 images, 8 workers):
Notes:
The added overhead is due to the additional processing required to remove overlaps in the segmentation masks. Further optimizations may be explored if necessary.
Update:
After further optimizations there is no overhead anymore.