Skip to content

Conversation

@JSabadin
Copy link
Contributor

@JSabadin JSabadin commented May 19, 2025

Purpose

Bug description:
When a dataset created on GCS is pulled down to Machine B and used as a local dataset, attempting to merge it with another local dataset on Machine B produces an invalid dataset. Notably, merging two datasets directly on the cloud from different machines worked correctly prior to this.

This edge case has been addressed in this PR, and a corresponding test has been added.

Additionally, the export now includes metadata such as text for OCR.

Specification

None / not applicable

Dependencies & Potential Impact

None / not applicable

Deployment Plan

None / not applicable

Testing & Validation

None / not applicable

@JSabadin JSabadin requested a review from a team as a code owner May 19, 2025 13:47
@JSabadin JSabadin requested review from conorsim, klemen1999, kozlov721 and tersekmatija and removed request for a team May 19, 2025 13:47
@github-actions github-actions bot added the fix Fixing a bug label May 19, 2025
@codecov
Copy link

codecov bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.57%. Comparing base (f2cf992) to head (c7d8f73).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
luxonis_ml/data/datasets/luxonis_dataset.py 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #327      +/-   ##
==========================================
+ Coverage   95.55%   95.57%   +0.02%     
==========================================
  Files         102      102              
  Lines        6071     6104      +33     
==========================================
+ Hits         5801     5834      +33     
  Misses        270      270              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added tests Adding or changing tests data Changes affecting luxonis_ml.data subpackage CLI Changes affecting the CLI labels May 20, 2025
@JSabadin JSabadin changed the title Fix the dataset merge on Machine B Fix the dataset merge, export on Machine B May 20, 2025
@JSabadin JSabadin merged commit 92d4d38 into main Jun 3, 2025
15 of 16 checks passed
@JSabadin JSabadin deleted the fix/merge-on-machine-B branch June 3, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLI Changes affecting the CLI data Changes affecting luxonis_ml.data subpackage fix Fixing a bug tests Adding or changing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants