Skip to content

Conversation

@kozlov721
Copy link
Collaborator

Purpose

The LuxonisDataset.export method now also exports multi-task datasets and can handle "metadata" fields.

Specification

None / not applicable

Dependencies & Potential Impact

None / not applicable

Deployment Plan

None / not applicable

Testing & Validation

None / not applicable

@kozlov721 kozlov721 requested a review from a team as a code owner July 11, 2025 01:09
@kozlov721 kozlov721 requested review from conorsim, klemen1999 and tersekmatija and removed request for a team July 11, 2025 01:09
@github-actions github-actions bot added the fix Fixing a bug label Jul 11, 2025
@github-actions github-actions bot added data Changes affecting luxonis_ml.data subpackage CLI Changes affecting the CLI labels Jul 11, 2025
@codecov
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.61%. Comparing base (30d6f1a) to head (715a8d2).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
luxonis_ml/data/datasets/luxonis_dataset.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
+ Coverage   95.58%   95.61%   +0.02%     
==========================================
  Files         102      102              
  Lines        6118     6113       -5     
==========================================
- Hits         5848     5845       -3     
+ Misses        270      268       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@klemen1999 klemen1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the change that makes it now work? Becuase I see removal of the checks, no new code that would make the "multi-task dataset export" work.

@kozlov721
Copy link
Collaborator Author

There was nothing really preventing it from working apart from the checks. I don't rememeber why it wasn't enabled in the first place.

@kozlov721 kozlov721 merged commit adb6ca6 into main Jul 15, 2025
15 of 16 checks passed
@kozlov721 kozlov721 deleted the fix/export branch July 15, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLI Changes affecting the CLI data Changes affecting luxonis_ml.data subpackage fix Fixing a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants