Skip to content

Conversation

@JSabadin
Copy link
Contributor

@JSabadin JSabadin commented Jul 21, 2025

Purpose

Issues:

  • If the dataset contains duplicates, parsing will fail with the error
    “Dataset size is smaller than the total number of files in the definitions.”
  • Calling .make_splits(definitions) would fail if the definitions included extra files or if the dataset contained duplicate files.

Now when calling .make_splits(definitions), we simply remove duplicate entries, ignore any extra paths in the definitions, and log about it.

Specification

None / not applicable

Dependencies & Potential Impact

None / not applicable

Deployment Plan

None / not applicable

Testing & Validation

None / not applicable

@JSabadin JSabadin requested a review from a team as a code owner July 21, 2025 10:20
@JSabadin JSabadin requested review from conorsim, klemen1999, kozlov721 and tersekmatija and removed request for a team July 21, 2025 10:20
@github-actions github-actions bot added the fix Fixing a bug label Jul 21, 2025
@codecov
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.26%. Comparing base (7758853) to head (e0cacaa).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
luxonis_ml/data/datasets/luxonis_dataset.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
- Coverage   95.29%   95.26%   -0.03%     
==========================================
  Files         103      103              
  Lines        6328     6332       +4     
==========================================
+ Hits         6030     6032       +2     
- Misses        298      300       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JSabadin JSabadin merged commit aa9ee35 into main Jul 25, 2025
14 of 16 checks passed
@JSabadin JSabadin deleted the fix/make-splits branch July 25, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Fixing a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants