Skip to content

Conversation

@kozlov721
Copy link
Collaborator

Purpose

Makes it more clear that no deletion was performed when user doesn't specify the deletion target in luxonis_ml data delete.

Specification

  • Changed message color to red
  • Changed exit code to 1

Dependencies & Potential Impact

None / not applicable

Deployment Plan

None / not applicable

Testing & Validation

None / not applicable

@kozlov721 kozlov721 requested a review from a team as a code owner July 22, 2025 15:30
@kozlov721 kozlov721 requested review from conorsim, klemen1999 and tersekmatija and removed request for a team July 22, 2025 15:30
@github-actions github-actions bot added fix Fixing a bug data Changes affecting luxonis_ml.data subpackage CLI Changes affecting the CLI labels Jul 22, 2025
@codecov
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.29%. Comparing base (a4d4c29) to head (4d7bb40).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
- Coverage   95.41%   95.29%   -0.13%     
==========================================
  Files         102      103       +1     
  Lines        6174     6328     +154     
==========================================
+ Hits         5891     6030     +139     
- Misses        283      298      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozlov721 kozlov721 merged commit 3b52066 into main Jul 22, 2025
15 of 16 checks passed
@kozlov721 kozlov721 deleted the fix/color-cli branch July 22, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLI Changes affecting the CLI data Changes affecting luxonis_ml.data subpackage fix Fixing a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants