Use _list_images for image iteration in CLSDIR parser. #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces direct directory iteration with the _list_images method in ClassificationDirectoryParser. This ensures consistent image file filtering and handling.
kkeroo
requested review from
conorsim,
klemen1999,
kozlov721 and
tersekmatija
and removed request for
a team
kozlov721
approved these changes
Oct 30, 2025
klemen1999
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Previously, we were iterating over all files in the directory including hidden files (e.g. .DS_Store file that MacOS attaches), this breaks the image loading with
LuxonisLoaderbecause cv2 can not read such files.Specification
Replaces direct directory iteration with the _list_images method in ClassificationDirectoryParser. This ensures consistent image file filtering and handling.
Dependencies & Potential Impact
None / not applicable
Deployment Plan
None / not applicable
Testing & Validation
None / not applicable