Exporter Refactor #372
Closed
Exporter Refactor #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…annotation type for now
dtronmans
requested review from
conorsim,
klemen1999,
kozlov721 and
tersekmatija
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To separate different parts of the exporter to allow the functionality to be extended to different export types like COCO. Preparing the LDF is separated and common to all exporters, then each exporter defines a transform method. Each exporter inherits from BaseExporter, in a similar way that each parser inherits from BaseParser.
I also implemented the COCO parser separately with this structure, this will be added after this exporter structure is accepted.
Specification
The separation of concerns just makes the export function more extensible, and for now is only applied to the Native dataset type.
Dependencies & Potential Impact
Deployment Plan
Testing & Validation
The tests/test_data/test_export.py has already-existing tests for the export function that parse, export then parse again. This will be extended to test the COCO exporter once it is implemented in the same Parse -> Export -> Parse structure.