-
Notifications
You must be signed in to change notification settings - Fork 1
Extend dataset export functionality to all different DatasetTypes #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…annotation type for now
kozlov721
reviewed
Nov 12, 2025
Collaborator
kozlov721
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thamks. Left some few comments. Otherwise I think it looks good
klemen1999
reviewed
Nov 17, 2025
klemen1999
approved these changes
Nov 20, 2025
Collaborator
klemen1999
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Go from only being able to export with DatasetType.NATIVE to all DatasetType entries.
Specification
Dependencies & Potential Impact
Deployment Plan
Testing & Validation
The first way I tested the correctness of the functionality is to parse datasets, export them using the exporters then open them with different tools like Roboflow and FiftyOne:
The second and more precise way is by writing tests in tests/test_data/test_parse_export_equivalence.py, in which the following is tested: