Skip to content

[Feat] Added name attribute to HeadType #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2024
Merged

[Feat] Added name attribute to HeadType #86

merged 2 commits into from
Oct 3, 2024

Conversation

@klemen1999
Copy link
Collaborator

@klemen1999 klemen1999 commented Oct 1, 2024

  • Added name attribute to head when automatically generating NNArchive (Related to this luxonis-ml PR)
  • Fixed output names for EfficientBboxHead to fit DAI requirements. This is only triggered if user doesn't specify the output names through config.

@klemen1999 klemen1999 requested a review from a team as a code owner October 1, 2024 19:13
@klemen1999 klemen1999 requested review from conorsim, kozlov721 and tersekmatija and removed request for a team October 1, 2024 19:13
@github-actions github-actions bot added the enhancement New feature or request label Oct 1, 2024
@codecov
Copy link

codecov bot commented Oct 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (dev@c97f921). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
luxonis_train/core/utils/archive_utils.py 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff           @@
##             dev      #86   +/-   ##
======================================
  Coverage       ?   96.54%           
======================================
  Files          ?      143           
  Lines          ?     6309           
  Branches       ?        0           
======================================
  Hits           ?     6091           
  Misses         ?      218           
  Partials       ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kozlov721
kozlov721 approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@kozlov721 kozlov721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlov721 kozlov721 merged commit 8f896ce into dev Oct 3, 2024
9 checks passed
@kozlov721 kozlov721 deleted the feat/add_head_name_att branch October 3, 2024 17:19
kozlov721 pushed a commit that referenced this pull request Oct 9, 2024
@klemen1999 @kozlov721
[Feat] Added name attribute to HeadType (#86)
c8050df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kozlov721 kozlov721 kozlov721 approved these changes

@tersekmatija tersekmatija Awaiting requested review from tersekmatija tersekmatija was automatically assigned from luxonis/ml-reviewers

@conorsim conorsim Awaiting requested review from conorsim conorsim was automatically assigned from luxonis/ml-reviewers

Assignees

@klemen1999 klemen1999

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@klemen1999 @kozlov721