Remove online part. #178
Draft
Remove online part. #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkeroo
requested review from
conorsim,
klemen1999,
kozlov721 and
tersekmatija
and removed request for
a team
kozlov721
approved these changes
Nov 4, 2025
klemen1999
reviewed
Nov 4, 2025
Collaborator
klemen1999
left a comment
klemen1999
left a comment
There was a problem hiding this comment.
There are some mentions of the online usage in the main README as well that should be removed
Eliminated imports and references to the hub module from __init__.py and __main__.py, likely due to deprecation or refactoring of hub functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors and simplifies the codebase by removing unused or redundant code related to online model conversion and the HubAI integration, and by reorganizing imports for better maintainability. It also updates the documentation to clarify the preferred method for online conversion.
Documentation update:
README.mdfile now recommends using the HubAI SDK for online model conversion, replacing the previous detailed CLI and Python usage instructions.Code cleanup and refactoring:
hubmodule frommodelconverter/__init__.pyandmodelconverter/__main__.py, streamlining the main entry points. [1] [2] [3]Requestto usemodelconverter.utils.hub_requestsinstead ofmodelconverter.hub.hub_requestsinmodelconverter/cli/utils.py, reflecting the new module structure.modelconverter/cli/utils.py, includingprint_hub_resource_info,hub_ls,is_valid_uuid,get_resource_id,request_info,get_variant_name,get_version_number,wait_for_export, andget_target_specific_options. This reduces complexity and removes code that is no longer needed. [1] [2]