factory test depth #403
Open
factory test depth #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saching13
commented
Sep 15, 2022
Contributor
Author
saching13
left a comment
saching13
left a comment
There was a problem hiding this comment.
Can you address these ?
daxoft
force-pushed
the
daxoft/depth_test
branch
from
4b434d6 to
76c73d9
Compare
saching13
commented
Sep 27, 2022
depth_test/depthtest.py
Outdated
| gt_plane = (gt_normal, -self.true_distance) | ||
| gt_plane_dist = roi_point.dot(gt_plane[0]) + gt_plane[1] | ||
| plane_offset_error += fitPlaneDist | ||
| gt_offset_error += gt_plane_dist |
Contributor
Author
There was a problem hiding this comment.
Change this to Absolute error. Naming adjustment.
depth_test/depthtest.py
Outdated
| elif self.ui.r_center.isChecked(): | ||
| side = 'center' | ||
| file.write(f'{int(time.time())},{mx_id},{self.true_distance},{self.z_distance},{self.plane_fit_mse},\ | ||
| {self.gt_plane_mse},{self.plane_fit_rmse},{self.max_error},{self.min_plane_error},\ |
Contributor
Author
There was a problem hiding this comment.
Change gt_plane_mse -> gt_plane abs error in the header
Contributor
|
daxoft
force-pushed
the
daxoft/depth_test
branch
from
1b9c4e1 to
57a7a9f
Compare
daxoft
force-pushed
the
daxoft/depth_test
branch
from
d2afe30 to
f1cb2a8
Compare
…ments into daxoft/depth_test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.