Skip to content

Comments

Data Collection Hub App#770

Merged
klemen1999 merged 70 commits intomainfrom
hub_snapping
Dec 9, 2025
Merged

Data Collection Hub App#770
klemen1999 merged 70 commits intomainfrom
hub_snapping

Conversation

@FSAFTik
Copy link
Contributor

@FSAFTik FSAFTik commented Oct 27, 2025

Purpose

Complete data collection application for snapping frames from the stream to hub under certain set conditions

Specification

None / not applicable

Dependencies & Potential Impact

Depends on snaps v2 from future depthAI 3.2.0 release and depthai-nodes branch : feat/dai_dev_req_TEST_GROUP

Deployment Plan

Requires both of the dependencies to be merged to main

Testing & Validation

Manual testing of all of the available snapping conditions in different situations

@FSAFTik FSAFTik requested a review from PetrNovota October 27, 2025 12:28
@klemen1999
Copy link
Collaborator

Couple of notes:

  • Do we need both Data Collection app and the Hub Snaps PoC? If I understand correctly these are two very similar apps where Hub Snaps is basically the updated of the "Data Collection" one? If that is the case I would only keep the better one and rename that one to "Data Collection" (or some better name but not the "hub snaps" as this is too obscure IMO)
  • IMO we should put performant POCs under the existing apps directory instead of creating a new one
  • We should update the test constants map to include new examples as they have some limitations on how can they be ran (i.e. the apps work only in standalone rvc4 I assume)

@FSAFTik FSAFTik added the testable PR is ready to be tested label Oct 30, 2025
@PetrNovota
Copy link
Contributor

@FSAFTik is working on a refactor right now. This is not presentable in its current form

@PetrNovota
Copy link
Contributor

@klemen1999

Do we need both Data Collection app and the Hub Snaps PoC?

where is this second app?

IMO we should put performant POCs under the existing apps directory instead of creating a new one

Agree, we will move all performant PoCs under apps

@FSAFTik
Copy link
Contributor Author

FSAFTik commented Oct 30, 2025

where is this second app?
I did delete it on current branch

@PetrNovota PetrNovota changed the title Hub snapping Data Collection Hub App Nov 27, 2025
Copy link
Collaborator

@klemen1999 klemen1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some updates need to be made before merge

@klemen1999 klemen1999 merged commit ceda14e into main Dec 9, 2025
8 checks passed
@klemen1999 klemen1999 deleted the hub_snapping branch December 9, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testable PR is ready to be tested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants