Skip to content

RP2040: PWM pin signature change #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

RP2040: PWM pin signature change #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions rp2040_u2if.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,7 @@ def neopixel_write(self, gpio, buf):
def pwm_configure(self, pin, frequency=500, duty_cycle=0, variable_frequency=False):
"""Configure PWM."""
self.pwm_deinit(pin)
resp = self._hid_xfer(bytes([self.PWM_INIT_PIN, pin.id]), True)
resp = self._hid_xfer(bytes([self.PWM_INIT_PIN, pin]), True)
if resp[1] != self.RESP_OK:
raise RuntimeError("PWM init error.")

Expand All @@ -480,19 +480,19 @@ def pwm_configure(self, pin, frequency=500, duty_cycle=0, variable_frequency=Fal

def pwm_deinit(self, pin):
"""Deinit PWM."""
self._hid_xfer(bytes([self.PWM_DEINIT_PIN, pin.id]))
self._hid_xfer(bytes([self.PWM_DEINIT_PIN, pin]))

def pwm_get_frequency(self, pin):
"""PWM get freq."""
resp = self._hid_xfer(bytes([self.PWM_GET_FREQ, pin.id]), True)
resp = self._hid_xfer(bytes([self.PWM_GET_FREQ, pin]), True)
if resp[1] != self.RESP_OK:
raise RuntimeError("PWM get frequency error.")
return int.from_bytes(resp[3 : 3 + 4], byteorder="little")

def pwm_set_frequency(self, pin, frequency):
"""PWM set freq."""
resp = self._hid_xfer(
bytes([self.PWM_SET_FREQ, pin.id])
bytes([self.PWM_SET_FREQ, pin])
+ frequency.to_bytes(4, byteorder="little"),
True,
)
Expand All @@ -509,15 +509,15 @@ def pwm_set_frequency(self, pin, frequency):

def pwm_get_duty_cycle(self, pin):
"""PWM get duty cycle."""
resp = self._hid_xfer(bytes([self.PWM_GET_DUTY_U16, pin.id]), True)
resp = self._hid_xfer(bytes([self.PWM_GET_DUTY_U16, pin]), True)
if resp[1] != self.RESP_OK:
raise RuntimeError("PWM get duty cycle error.")
return int.from_bytes(resp[3 : 3 + 4], byteorder="little")

def pwm_set_duty_cycle(self, pin, duty_cycle):
"""PWM set duty cycle."""
resp = self._hid_xfer(
bytes([self.PWM_SET_DUTY_U16, pin.id])
bytes([self.PWM_SET_DUTY_U16, pin])
+ duty_cycle.to_bytes(2, byteorder="little"),
True,
)
Expand Down