Closed
Conversation
Collaborator
|
Thanks! Let's get the #57 merged in first, then rebase and review @HonzaCuhel . In the meantime, let's get the ONNX and blobs shared internally so we can start integrating protos into the FW @Mruzik1 . |
Contributor
|
Sure! I want to first update the automatic version detection and then I'll merge it and deploy it. Is that okay, @tersekmatija ? Or should I merge the #57 now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
YoloV5Exporter, overridesload_modelandexport_onnx, has a new methodprune_model.Exporterclass.get_onnxandexport_openvino). Using the name is maybe not the best way to check the type. Although it has its own pros, plus we don't need to import anything that could affect flexibility ofExporter.'->") in the openvino command, because I had an error with those.test_seg_export.py+ foldermodel_filesfor generated files to test the changes.