Skip to content

Conversation

@MartinHruza
Copy link

@dubhater
Copy link
Collaborator

dubhater commented Apr 8, 2025

Looks mostly good to me.

  • The initial gain values are backwards: larger values lower the gain, smaller values increase the gain. So 0x1c results in maximum gain and 0x5a results in minimum gain. Using 0x2a helps in your case because normally it's probably choosing ~0x40.

  • Another thing I wonder is if you should go lower than rtwdev->chip->dig_min. For some chips it's 0x1c, for others it's 0x20.

  • Lastly, you should send the patch to the linux-wireless mailing list. Some more information about that: https://www.kernel.org/doc/html/latest/process/submitting-patches.html

- This patch temporarily increases the rx gain before scanning and reset
  it back to the last recorded value once the scanning finishes.
- Ref: lwfinger#337
@MartinHruza MartinHruza force-pushed the adjust-igi-before-scan branch from 590b51b to aa08be9 Compare April 9, 2025 18:54
@LuisMitaHL
Copy link

Works on rtl8812au

LuisMitaHL added a commit to LuisMitaHL/rtw88-openwrt that referenced this pull request Apr 16, 2025
@LuisMitaHL
Copy link

Hi, there is any updates on this patch?

@dubhater
Copy link
Collaborator

It looks like the author vanished, but anyone can send the patch to the mailing list (with proper credit). Just replace DIG_CVRG_MAX with DIG_CVRG_MIN to make it do what the description says.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants