Add TSF debugfs support for RTL8821CU #400
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new debugfs interface for the Timing Synchronization Function (TSF) specifically for the RTL8821CU chipset. The following changes were made: - Added `rtw_debugfs_get_tsf` to read the 64-bit TSF value from the correct hardware registers (0x0560 and 0x0564). - Added `rtw_debugfs_set_tsf` to allow writing a new TSF value or resetting TSF using the "reset" command. Writes update registers 0x0560 (lower 32 bits) and 0x0564 (upper 32 bits). - Updated the `rtw_debugfs_priv` structure to include TSF support. - Ensures proper locking via the device mutex to prevent race conditions when accessing TSF registers. - Provides debug logging via `rtw_info` for TSF read/write operations. - Creates the TSF debugfs file at `/sys/kernel/debug/ieee80211/phy*/rtw88/tsf`. This feature allows developers and testers to monitor and manipulate the TSF for debugging and performance evaluation purposes.
Collaborator
|
Please email your patch to linux-wireless at vger.kernel.org and pkshih at realtek.com. |
Author
|
Ok, I'll do that! I want to clarify that the TSF debugfs functionality has only been tested and verified on the RTL8821CU chipset. Other rtw88 devices may work, but I haven’t verified them yet, so testing is needed. Based on my research of the hardware registers, similar TSF register addresses appear on the following chipsets: USB Wi-Fi Chips: RTL8822CU PCIe Wi-Fi Chips Supported: RTL8822BE/BU Testing on these devices would help confirm whether the TSF debugfs functionality works across the wider rtw88 family. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new debugfs interface for the Timing Synchronization Function (TSF) specifically for the RTL8821CU chipset.
The following changes were made:
rtw_debugfs_get_tsfto read the 64-bit TSF value from the correct hardware registers (0x0560 and 0x0564).rtw_debugfs_set_tsfto allow writing a new TSF value or resetting TSF using the "reset" command. Writes update registers 0x0560 (lower 32 bits) and 0x0564 (upper 32 bits).rtw_debugfs_privstructure to include TSF support.rtw_infofor TSF read/write operations./sys/kernel/debug/ieee80211/phy*/rtw88/tsf.This feature allows developers and testers to monitor and manipulate the TSF for debugging and performance evaluation purposes.