-
Notifications
You must be signed in to change notification settings - Fork 29
Add ability to see main members in groups #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Please remove the changes to translations from your PR. |
Oh, are they automated? |
It is mostly correcting the line numbers, and adding the new, missing entries. |
Translation updates are done separately, by @stefonarch . Code PRs shouldn't touch translation files. |
Done! |
Thanks for the PR and also for cleaning it up. I requested a review. |
Sorry, but I don't see a benefit of having visually separated list of main member. Wouldn't it be enough just to assure, that the main member is always first in the list of members? |
There can be more than one main member in a group. |
Sure, and what is the purpose of showing them in GUI separated list? |
Users can both be a main member and a normal member of a group at the same time. How should that be shown in the group GUI? However, I find it understandable to show both normal and main members in the same column in the group list GUI. |
First in the list with disabled checkbox? |
Then there will be both the main members with checkbox disabled and and normal members with selectable checkboxes, which will ALWAYS include the main members as normal users, since they must also be controlled if they are normal members or not. This means that there will 2 entries for every member, if they are a main member, which will be confusing, especially for new people to this program. |
I could move the main members list to be over the normal members, and make the main members list thin. |
Adds the ability to see main members in groups. (Inverse of a user's main group)
Also fixes the translation file lxqt-admin-user_kab.ts
Edit: This can be done by @stefonarch instead.
As Im new to C++, I just want to make sure this is safe and good:
Screenshots
When adding a new group: