Skip to content

plugin-mainmenu: Use groupbox and simplify config GUI #2313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

isf63
Copy link
Contributor

@isf63 isf63 commented Jul 19, 2025

This is somewhat unimportant due to Fancy Menu being the new default, but it reduces GUI code and should speed up builds.

Arguably it makes the GUI more clear, unless nested groupboxes are a point of confusion.

@isf63
Copy link
Contributor Author

isf63 commented Jul 20, 2025

Editing the .cpp file revealed that static_cast and QOverload<> for signals are used throughout the whole source. They can be removed due to Qt6 improvements with the goal of lighter compiling.

@tsujan
Copy link
Member

tsujan commented Jul 20, 2025

Editing the .cpp file revealed that static_cast and QOverload<> for signals are used throughout the whole source.

They're remnants of old times. They're safe, but I remove them in sources that I work on (in my PRs).

I'll review this PR later, being madly busy for now.

@isf63
Copy link
Contributor Author

isf63 commented Jul 23, 2025

Compilation would be sped up by removing all unnecessary QOverloads/signal casts, because they're complex templates, no? My motivation is to improve compilation times despite lxqt-panel's innate complexity.

@tsujan
Copy link
Member

tsujan commented Jul 23, 2025

Compilation would be sped up

Not in reality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants