Skip to content

move labwc configurations from default location #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sfalken
Copy link

@sfalken sfalken commented Jan 19, 2025

Move initial configs from $XDG_CONFIG_HOME/labwc to $XDG_CONFIG_HOME/lxqt/labwc With them in the default labwc configuring locations, the lxqt configurations stomp on the bare labwc
configurations. We'd like to avoid this, for folks that use both.

Move initial configs from $XDG_CONFIG_HOME/labwc to
$XDG_CONFIG_HOME/lxqt/labwc  With them in the default labwc
configuring locations, the lxqt configurations stomp on the bare labwc
configurations.   We'd like to avoid this, for folks that use both.
@stefonarch
Copy link
Member

We decided not to do so because labwc and kwin allow starting the session directly.

  1. When labwc is already configured and used nothing will be copied and nothing is needed except configuring shortcuts eventually.
  2. as it is this is will be backwards incompatible, falling back to a default session for users.

With kwin it's not even possible using different configurations.

The path shoud be $XDG_CONFIG_HOME/lxqt/wayland/labwc.

@tsujan
Copy link
Member

tsujan commented Jan 19, 2025

I completely agree with @stefonarch.

@sfalken
Copy link
Author

sfalken commented Jan 19, 2025

I don't see any compelling reason to add an extra nested layer of directories, but it's not a big deal.

WRT the labwc configs, it's entirely possible, for somebody that's otherwise using labwc without lxqt, to have their configs stored in the default location of ~/.config/labwc install the lxqt-labwc session, and end up with an incredibly screwy desktop, that doesn't coordinate well with the lxqt session, due to the existence of statusbars, autostarts, or other configurations.

I think avoiding that is a good thing, by not putting the lxqt-labwc configurations in the default labwc config location, and instead keeping the configurations seperate. Regular labwc users can easily copy over whatever they want to add from their "raw" labwc configs, into the lxqt-labwc configurations, if they so wish.

It's not lxqt upstreams issue, but we're already running into this with the sway session on openSUSE, due to the way our sway packaging works. The default sway configs that come with our packages conflict something fierce with the configurations provided by lxqt-sway.

(Note, sway is handled properly (to my way of thinking) here in lxqt-wayland-session, as the sway configuration is being put in a place sway normally wouldn't look for it, and the alternate location is being sourced via the startlxqtwayland script. Our config problems on openSUSE are due to sway, not lxqt.)

Move from $XDG_CONFIG_HOME/lxqt/labwc to
$XDG_CONFIG_HOME/lxqt/wayland/labwc
@stefonarch
Copy link
Member

stefonarch commented Jan 19, 2025

due to the existence of statusbars, autostarts, or other configurations.

That is a point, I admit, but we did never encounter a complaint about and I think labwc is the most used atm.

But I can't see any easy and clean way to avoid backwards compatibility. But I think it's no issue when a specific distro changes the settings location for labwc, we can add it to the wiki.

@sfalken
Copy link
Author

sfalken commented Jan 19, 2025

I don't understand what you mean by "backwards compatibility" I've no issue just doing this through downstream patching, if upstream is good with how things work now.

@stefonarch
Copy link
Member

I don't understand what you mean by "backwards compatibility" I've no issue just doing this through downstream patching, if upstream is good with how things work now.

After updating lxqt-wayland-session any existing labwc user would find himself with a config new from scratch.

@stefonarch
Copy link
Member

FYI: labwc-tweaks works atm only with the default location, see
lxqt/lxqt#2686 (reply in thread)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants