More correct XDG_CURRENT_DESKTOP env vars #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsujan
reviewed
May 18, 2025
| @@ -113,6 +113,7 @@ elif [ "$COMPOSITOR" = "labwc" ]; then | |||
| exec $COMPOSITOR -C $XDG_CONFIG_HOME/labwc -S lxqt-session | |||
|
|
|||
| elif [ "$COMPOSITOR" = "niri" ]; then | |||
| export XDG_CURRENT_DESKTOP="LXQt:$COMPOSITOR:smithay" | |||
There was a problem hiding this comment.
With this, I don't think the wlroots backend will be used.
tsujan
reviewed
May 18, 2025
| @@ -164,6 +165,7 @@ elif [ "$COMPOSITOR" = "sway" ]; then | |||
| exec $COMPOSITOR -c $XDG_CONFIG_HOME/lxqt/wayland/lxqt-sway.config | |||
|
|
|||
| elif [ "$COMPOSITOR" = "Hyprland" ]; then | |||
| export XDG_CURRENT_DESKTOP="LXQt:$COMPOSITOR:aquamarine" | |||
There was a problem hiding this comment.
Yes, it needs lxqt/lxqt-panel#2282
There was a problem hiding this comment.
Not from my experience ;)
There was a problem hiding this comment.
Perhaps because you use your deleted PR. But, in the end, that's no relevant. I'm adding a comment to lxqt/lxqt-panel#2282.
There was a problem hiding this comment.
This should work after lxqt/lxqt-panel#2283 is merged — as you already know.
This was referenced May 18, 2025
|
I have no problem with merging this after the recent changes. But since I can't test it thoroughly, please merge it after such a test, which only you can do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.