Skip to content

Add QTermWidget::addCustomKeyboardLayoutDir #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add QTermWidget::addCustomKeyboardLayoutDir #591

wants to merge 1 commit into from

Conversation

KangLin
Copy link

@KangLin KangLin commented Jul 2, 2025

Add

  • QTermWidget::addCustomKeyboardLayoutDir(const QString& custom_dir)
  • void add_custom_color_scheme_dir(const QString& custom_dir)

@KangLin KangLin force-pushed the keyboardlayout branch 4 times, most recently from da72344 to e9e5d07 Compare July 2, 2025 03:46
@KangLin
Add
312b63e 
- QTermWidget::addCustomKeyboardLayoutDir(const QString& custom_dir)
- void add_custom_color_scheme_dir(const QString& custom_dir)
tsujan
tsujan reviewed Jul 4, 2025
View reviewed changes
lib/tools.cpp
k = QCoreApplication::applicationDirPath()
+ QDir::separator() + QLatin1String("..")
+ QDir::separator() + QLatin1String("share")
+ QDir::separator() + QLatin1String("qtermwidget6")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had time to check the whole patch, but "share" and "qtermwidget6" shouldn't be hard coded.

Also, this number of QDir::separator() looks ugly. We don't (and won't) support MS Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsujan tsujan tsujan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KangLin @tsujan