Conversation
Contributor
Author
|
The more I think about this, the more I wonder if instead of this approach we should have a third queue that is like in between normal and slow. Maybe semi-slow? I just wonder if we actually have to slow down as much as we are. Maybe a future action item. |
smonero
changed the title
miguelmolina95
previously approved these changes
May 7, 2024
| } | ||
|
|
||
| func IsPRAutomated(pr *github.PullRequest) bool { | ||
| if pr.Labels == nil { |
There was a problem hiding this comment.
https://pkg.go.dev/github.com/google/go-github/v45/github#PullRequest
Labels []*[Label](https://pkg.go.dev/github.com/google/go-github/v45/github#Label) `json:"labels,omitempty"`
it's better to check zero length for a slice instead of nil, because there can be empty allocated slice.
abhinavdahiya
approved these changes
May 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was said that we can use the slow task queue for
automatedPRs aka refactorator PRs.