Skip to content

[DEVCON-2524] output deploy queue to checkrun summary #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 3, 2024
Merged

[DEVCON-2524] output deploy queue to checkrun summary #772

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4a5c4a0
add revisions on queue to checkrun summary
tlin4194 Oct 25, 2024
a986769
update tests with GetQueuedRevisionsSummary queue interface
tlin4194 Oct 26, 2024
f9f0431
fix updater and revision tests to throw errors from child workflow
tlin4194 Oct 28, 2024
f4e8ac5
exposing deploy queue to deploy terraform package
tlin4194 Oct 30, 2024
2334947
add commit links
tlin4194 Oct 30, 2024
fd38bf6
update checkruns with queue status for Terraform jobs where Apply ste…
tlin4194 Oct 30, 2024
43ccc09
fix deploy_test by checking apply job is not null
tlin4194 Oct 30, 2024
cbf4fa5
provide links to runs in queue instead of commits in queue
tlin4194 Oct 31, 2024
4cc6c9f
add comments, replace using reflect to check for empty Apply.Onwaitin…
tlin4194 Nov 7, 2024
1e2c0a8
workflow version patch for additional github checkrun updates due to …
tlin4194 Nov 7, 2024
c921b26
bugfix: after confirm action, queued checkruns need to be restored to…
tlin4194 Nov 7, 2024
d5ef226
noted TODO: current deploy checkrun is updated twice on confirm/rejec…
tlin4194 Nov 7, 2024
d31039c
Restore unlock action on queued checkruns (#774)
tlin4194 Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions server/neptune/workflows/internal/deploy/terraform/state.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package terraform

import (
"fmt"
"reflect"

"github.com/pkg/errors"
"github.com/runatlantis/atlantis/server/metrics"
Expand Down Expand Up @@ -32,6 +31,8 @@ type StateReceiver struct {
}

func (n *StateReceiver) Receive(ctx workflow.Context, c workflow.ReceiveChannel, deploymentInfo DeploymentInfo) {
// deploymentInfo is the current deployment being processed in TerraformWorkflow. Receive is triggered whenever the TerraformWorkflow has a state change.

var workflowState *state.Workflow
c.Receive(ctx, &workflowState)

Expand All @@ -48,18 +49,18 @@ func (n *StateReceiver) Receive(ctx workflow.Context, c workflow.ReceiveChannel,
}
}

// Updates all other deployments waiting in queue when the current deployment is pending a confirm/reject user action. Current deployment is not on the queue at this point since its child TerraformWorkflow was started.
if workflowState.Apply != nil &&
workflowState.Apply.Status == state.WaitingJobStatus &&
!reflect.ValueOf(workflowState.Apply.OnWaitingActions).IsZero() {
// update queue with information about current deployment pending confirm/reject action
infos := n.Queue.GetOrderedMergedItems()
len(workflowState.Apply.OnWaitingActions.Actions) > 0 {
queued_deployments := n.Queue.GetOrderedMergedItems()

revisionsSummary := n.Queue.GetQueuedRevisionsSummary()
state := github.CheckRunQueued
runLink := github.BuildRunURLMarkdown(deploymentInfo.Repo.GetFullName(), deploymentInfo.Commit.Revision, deploymentInfo.CheckRunID)
summary := fmt.Sprintf("This deploy is queued pending action on run for revision %s.\n%s", runLink, revisionsSummary)

for _, i := range infos {
for _, i := range queued_deployments {
request := notifier.GithubCheckRunRequest{
Title: notifier.BuildDeployCheckRunTitle(i.Root.Name),
Sha: i.Commit.Revision,
Expand All @@ -77,6 +78,7 @@ func (n *StateReceiver) Receive(ctx workflow.Context, c workflow.ReceiveChannel,
}
}

// Updates github check run with Terraform statuses for the current running deployment
for _, notifier := range n.InternalNotifiers {
if err := notifier.Notify(ctx, deploymentInfo.ToInternalInfo(), workflowState); err != nil {
workflow.GetMetricsHandler(ctx).Counter("notifier_failure").Inc(1)
Expand Down
Loading