allow specifying an endpoint_url override #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Need to update the tests, though :). Have you tested sending None into the endpoint url arg in the boto3 lib? |
doy-stripe
force-pushed
the
kms-endpoint
branch
from
d46f42f
to
6fe31ac
Compare
doy-stripe
force-pushed
the
kms-endpoint
branch
from
6fe31ac
to
3c25703
Compare
|
New change looks good too, excluding lint failure. Has this been tested, same question as before though, have you tested with sending None to the function in boto3? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KMS doesn't have in-VPC endpoints yet, so we need to be able to proxy our KMS requests through a known host in order to meaningfully restrict egress from our machines. This pull request allows overriding the KMS endpoint used by the AWS bindings. This relies on lyft/python-kmsauth#11 and so will also require a dependency bump once that is released.